Reduce ReallyBeIdle default ticks#6675
Merged
metalgearsloth merged 1 commit intoJun 28, 2026
Merged
Conversation
Contributor
|
Wouldn't syncticks be better / just getting client and server together? A lot of this is held together by hopes and dreams so don't see an issue merging if it doesn't cause more heisentests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function waits until the communication between client and server has been fully resolved using
WaitIdleAsync.By default this currently runs for 25 ticks and is part of the testpair recycling, intended to allow any slow failures to surface.
Researching this default value has yielded no justification for 25 - it appears to have been a "looks about right" value.
Reducing this to 5 still allows sufficient time for things to stabilize after a test without running tests significantly longer than necessary.
As a side point - this should be handled by tests themselves. Any test should run long enough to ensure that the result reported is valid. This functionality should be purely to ensure that nothing has failed catastrophically.
Reducing this value yields significant improvement in test duration from 984s to 810s on my machine.